[WIP] feat: playing sound from remote source #282
Conversation
tirz
force-pushed
the
feature-sound_via_network
branch
3 times, most recently
from
134f47b
to
84e45b0
Compare
Cargo.toml
Outdated
| @@ -15,6 +16,7 @@ hound = { version = "3.3.1", optional = true } | |||
| lazy_static = "1.0.0" | |||
| lewton = { version = "0.10", optional = true } | |||
| minimp3 = { version = "0.3.2", optional = true } | |||
| reqwest = { version = "0.9.0", default-features = false, features = ["rustls-tls"], optional = true } | |||
There was a problem hiding this comment.
Could you remove the rustls-tls feature from here, copy the reqwest dependency and add it below as a dev-dependency, with rustls-tls enabled? That way, users of rodio have free choice over the tls implementation.
| @@ -7,6 +7,7 @@ description = "Audio playback library" | |||
| keywords = ["audio", "playback", "gamedev"] | |||
| repository = "https://github.com/RustAudio/rodio" | |||
| documentation = "http://docs.rs/rodio" | |||
| autoexamples = true | |||
There was a problem hiding this comment.
This is redundant as true is already the default
There was a problem hiding this comment.
In fact I am not even sure if setting it to true have any effect...
But at least, it remove a warning.
Since I am setting an example like:
[[example]]
name = "http_flac"
path = "examples/http_flac.rs"
required-features = ["http"]
I got a warning:
warning: An explicit [[example]] section is specified in Cargo.toml which currently
disables Cargo from automatically inferring other example targets.
This inference behavior will change in the Rust 2018 edition and the following
files will be included as a example target:
* /home/tirz/Documents/Rust/rodio/examples/basic.rs
* /home/tirz/Documents/Rust/rodio/examples/music_mp3.rs
* /home/tirz/Documents/Rust/rodio/examples/music_flac.rs
* /home/tirz/Documents/Rust/rodio/examples/reverb.rs
* /home/tirz/Documents/Rust/rodio/examples/music_wav.rs
* /home/tirz/Documents/Rust/rodio/examples/music_ogg.rs
* /home/tirz/Documents/Rust/rodio/examples/spatial.rs
This is likely to break cargo build or cargo test as these files may not be
ready to be compiled as a example target today. You can future-proof yourself
and disable this warning by adding `autoexamples = false` to your [package]
section. You may also move the files to a location where Cargo would not
automatically infer them to be a target, such as in subfolders.
For more information on this warning you can consult
https://github.com/rust-lang/cargo/issues/5330
|
|
||
| fn main() { | ||
| let device = rodio::default_output_device().unwrap(); | ||
| let sink = rodio::Sink::new(&device); | ||
| let device = rodio::default_output_device().unwrap(); |
There was a problem hiding this comment.
Rodio uses spaces for indentation.
There was a problem hiding this comment.
I planed to run cargo fmt at the end of this PR but right now, I got an error because of my version of Rust.
Warning: Unknown configuration option `fn_args_density`
Warning: Unknown configuration option `fn_brace_style`
Warning: Unknown configuration option `fn_call_style`
Warning: Unknown configuration option `fn_empty_single_line`
Warning: Unknown configuration option `generics_indent`
Warning: Unknown configuration option `impl_empty_single_line`
Warning: Unknown configuration option `reorder_imported_names`
Warning: Unknown configuration option `reorder_imports_in_group`
Warning: Unknown configuration option `where_density`
Warning: Unknown configuration option `where_style`
Warning: Unknown configuration option `wrap_match_arms`
Warning: Unknown configuration option `write_mode`
Error: Decoding config file failed:
unknown variant `Visual`, expected one of `Compressed`, `Tall`, `Vertical` for key `fn_args_layout`
Please check your config file.
I will fix it later.
tirz
force-pushed
the
feature-sound_via_network
branch
2 times, most recently
from
4d223b0
to
01b3ce8
Compare
tirz
force-pushed
the
feature-sound_via_network
branch
from
01b3ce8
to
8f63649
Compare
|
Hey, sorry for my late, I was focused on another project. In fact this PR is already pretty stable... Do we need some unit test or just a |
|
I don't really want global cargo fmt to be run that changes all of rodio's source code, especially not in a PR that changes functional things. That way, you can't really inspect the changes any more. You are already now changing the formatting of files unrelated to the PR. Can you maybe file a separate PR, find stable alternatives to the rustfmt options present and then run cargo fmt? Also I'm not 100% convinced that this PR fits in the scope of rodio, as downloading might be done by games rather at the asset layer. |
dvdsk
force-pushed
the
master
branch
3 times, most recently
from
b10961c
to
a7f67b3
Compare
dvdsk
force-pushed
the
master
branch
4 times, most recently
from
0ee0413
to
073fdb1
Compare
WIP
run --example http_flac --features=https-rustlsis already working